Include EInk, Watch; fix type for formFactor #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two new values for the form-factor hint, and corrects the type of the `formFactor` property of `UADataValues`.
miketaylr
approved these changes
Sep 8, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 8, 2023
SHA: 20f56cc Reason: push, by miketaylr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Fwiw Samsung Internet runs on watches |
If I use the Samsung browser on my normal phone it doesn't show any UA client hints. Perhaps the browser on a watch is different (if you have one; please try it on my test site) but I expect it to be the same. |
Cool - didn't know that. :) If they decide to turn it on one day, SGTM. |
lukewarlow
added a commit
to lukewarlow/user-agent-data-types
that referenced
this pull request
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two new values for the form-factor hint, and corrects the type of the
formFactorproperty ofUADataValues.Both were omitted from #343, and brought to my attention by @lukewarlow and @nielsbasjes.
Preview | Diff