Add short descriptions for scan, catch, and switchMap #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerKiKi
reviewed
May 4, 2024
| @@ -416,16 +416,33 @@ If the subscriber has already been aborted (i.e., `subscriber.signal.aborted` is | |||
|
|
|||
| We propose the following operators in addition to the `Observable` interface: | |||
|
|
|||
| - `switchMap(mapFn)` | |||
| - Maps the value to a new observable, the subscribes to it, flattening its values | |||
There was a problem hiding this comment.
Suggested change
| - Maps the value to a new observable, the subscribes to it, flattening its values | |
| - Maps the value to a new observable, then subscribes to it, flattening its values |
PowerKiKi
reviewed
May 4, 2024
| - `catch()` | ||
| - Like `Promise.catch()`, it takes a mapping function which is fired if the observable | ||
| source emits an error. The mapping function should map into a new value which will be converted | ||
| into an observable with `from` interally and subscribed to in leiu of the errored source. |
There was a problem hiding this comment.
Suggested change
| into an observable with `from` interally and subscribed to in leiu of the errored source. | |
| into an observable with `from` internally and subscribed to in lieu of the errored source. |
|
@benlesh could you address the review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.