Make async steps explicitly "in parallel" with queued callbacks #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkruisselbrink maybe you can take a look? |
mkruisselbrink
approved these changes
Jul 5, 2023
The previous text described async operations by starting off with "queue a task" then just describing the remaining behavior synchronously, including invoking callbacks. It is more accurate to describe the async operations as starting off "in parallel", with any success/error callbacks being invoked by a queued task. Note that the task source remains implied rather than explicit, although it is called out with a new TODO.
inexorabletash
force-pushed
the
queue-invoke
branch
from
d74064a
to
d213f8e
Compare
|
@mkruisselbrink - can you take another look? (no rush at all, and if you'd prefer I find another reviewer please say!) |
github-actions bot
added a commit
that referenced
this pull request
Jul 18, 2023
SHA: 7753f1a Reason: push, by inexorabletash Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous text described async operations by starting off with "queue a task" then just describing the remaining behavior synchronously, including invoking callbacks.
It is more accurate to describe the async operations as starting off "in parallel", with any success/error callbacks being invoked by a queued task.
Note that the task source remains implied rather than explicit, although it is called out with a new issue.
Preview | Diff