Issue checkstyle#11720: Kill surviving mutation in RequireThisCheck r…

…elated to anonymous inner class
Vyom-Yadav · Jun 29, 2022 · e3aea5f · e3aea5f
1 parent c8c2d8c
commit e3aea5f
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 13 deletions.
diff --git a/.ci/pitest-suppressions/pitest-coding-require-this-check-suppressions.xml b/.ci/pitest-suppressions/pitest-coding-require-this-check-suppressions.xml
@@ -27,15 +27,6 @@
     <lineContent>&amp;&amp; ast.getParent().getType() != TokenTypes.LITERAL_CATCH) {</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>RequireThisCheck.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck</mutatedClass>
-    <mutatedMethod>endCollectingDeclarations</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
-    <description>removed conditional - replaced equality check with false</description>
-    <lineContent>if (isAnonymousClassDef(ast)) {</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>RequireThisCheck.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck</mutatedClass>

diff --git a/.ci/pitest-survival-check-html.sh b/.ci/pitest-survival-check-html.sh
@@ -199,7 +199,6 @@ pitest-coding-2)
 pitest-coding-require-this-check)
   declare -a ignoredItems=(
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>                        &#38;&#38; ast.getParent().getType() != TokenTypes.LITERAL_CATCH) {</span></pre></td></tr>"
-  "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>                if (isAnonymousClassDef(ast)) {</span></pre></td></tr>"
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>               &#38;&#38; parent.getType() != TokenTypes.CTOR_DEF</span></pre></td></tr>"
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>            &#38;&#38; lastChild.getType() == TokenTypes.OBJBLOCK;</span></pre></td></tr>"
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>            if (definitionToken.getType() == TokenTypes.STATIC_INIT) {</span></pre></td></tr>"

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java
@@ -175,9 +175,9 @@ public void testTokensNotNull() {
     @Test
     public void testWithAnonymousClass() throws Exception {
         final String[] expected = {
-            "28:25: " + getCheckMessage(MSG_METHOD, "doSideEffect", ""),
-            "32:24: " + getCheckMessage(MSG_VARIABLE, "bar", "InputRequireThisAnonymousEmpty."),
-            "55:17: " + getCheckMessage(MSG_VARIABLE, "foobar", ""),
+            "29:25: " + getCheckMessage(MSG_METHOD, "doSideEffect", ""),
+            "33:24: " + getCheckMessage(MSG_VARIABLE, "bar", "InputRequireThisAnonymousEmpty."),
+            "56:17: " + getCheckMessage(MSG_VARIABLE, "foobar", ""),
         };
         verifyWithInlineConfigParser(
                 getPath("InputRequireThisAnonymousEmpty.java"),
@@ -443,6 +443,14 @@ public void testRecordsDefault() throws Exception {
                 expected);
     }
 
+    @Test
+    public void testAnonymousInnerClass() throws Exception {
+        final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
+
+        verifyWithInlineConfigParser(
+            getPath("InputRequireThisAnonymousInnerClass.java"), expected);
+    }
+
     @Test
     public void testUnusedMethod() throws Exception {
         final DetailAstImpl ident = new DetailAstImpl();

diff --git a/...puppycrawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisAnonymousEmpty.java b/...puppycrawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisAnonymousEmpty.java
@@ -12,6 +12,7 @@
 public class InputRequireThisAnonymousEmpty {
 
     private int bar;
+    int a;
 
     interface AnonWithEmpty {
         public void fooEmpty();
@@ -56,4 +57,36 @@ public void fooEmpty() {
             }
         };
     }
+
+    void method2() {
+        int a = 1;
+        InputRequireThisAnonymousEmpty obj =
+            new InputRequireThisAnonymousEmpty() {
+                void method() {
+                    a += 1;
+                }
+            };
+    }
+
+    void anotherMethod() {
+        int var1 = 12;
+        int var2 = 13;
+        Foo obj = new Foo() {
+            void method() {
+                var2 += var1;
+            }
+        };
+        obj.getClass();
+    }
+}
+
+class SharkFoo {
+    int var1 = 12;
+}
+
+class Foo {
+    int var2 = 13;
+
+    class SharkFoo {
+    }
 }