Issue checkstyle#11140: solve more OCP_OVERLY_CONCRETE_PARAMETER

Vyom-Yadav · Aug 1, 2022 · a54849a · a54849a
1 parent a368230
commit a54849a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/javadoc/JavadocTypeCheck.java
@@ -495,7 +495,7 @@ private void checkComponentParamTag(DetailAST ast,
      * @param typeParamName the name of the type parameter
      */
     private void checkTypeParamTag(DetailAST ast,
-            List<JavadocTag> tags, String typeParamName) {
+            Collection<JavadocTag> tags, String typeParamName) {
         final String typeParamNameWithBrackets =
             OPEN_ANGLE_BRACKET + typeParamName + CLOSE_ANGLE_BRACKET;
 

diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/meta/MetadataGeneratorUtil.java b/src/main/java/com/puppycrawl/tools/checkstyle/meta/MetadataGeneratorUtil.java
@@ -37,6 +37,7 @@
 import com.puppycrawl.tools.checkstyle.TreeWalker;
 import com.puppycrawl.tools.checkstyle.api.AutomaticBean;
 import com.puppycrawl.tools.checkstyle.api.CheckstyleException;
+import com.puppycrawl.tools.checkstyle.api.RootModule;
 
 /** Class which handles all the metadata generation and writing calls. */
 public final class MetadataGeneratorUtil {
@@ -81,12 +82,12 @@ public static void generate(String path, OutputStream out, String... moduleFolde
      * Process files using the checker passed and write to corresponding XML files.
      *
      * @param moduleFolders folders to check
-     * @param checker checker
+     * @param root root module
      * @param path rootPath
      * @throws CheckstyleException checkstyleException
      * @throws IOException ioException
      */
-    private static void dumpMetadata(Checker checker, String path, String... moduleFolders)
+    private static void dumpMetadata(RootModule root, String path, String... moduleFolders)
             throws CheckstyleException,
             IOException {
         final List<File> validFiles = new ArrayList<>();
@@ -104,6 +105,6 @@ private static void dumpMetadata(Checker checker, String path, String... moduleF
                         .collect(Collectors.toList()));
             }
         }
-        checker.process(validFiles);
+        root.process(validFiles);
     }
 }