Issue checkstyle#11720: Kill surviving mutation in RequireThisCheck r…

…elated to anonymous inner class
Vyom-Yadav · Jun 28, 2022 · 2a06f77 · 2a06f77
1 parent c666b0e
commit 2a06f77
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 10 deletions.
diff --git a/.ci/pitest-suppressions/pitest-coding-require-this-check-suppressions.xml b/.ci/pitest-suppressions/pitest-coding-require-this-check-suppressions.xml
@@ -36,15 +36,6 @@
     <lineContent>&amp;&amp; ast.getParent().getType() != TokenTypes.LITERAL_CATCH) {</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>RequireThisCheck.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck</mutatedClass>
-    <mutatedMethod>endCollectingDeclarations</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.RemoveConditionalMutator_EQUAL_ELSE</mutator>
-    <description>removed conditional - replaced equality check with false</description>
-    <lineContent>if (isAnonymousClassDef(ast)) {</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>RequireThisCheck.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.coding.RequireThisCheck</mutatedClass>

diff --git a/.ci/pitest-survival-check-html.sh b/.ci/pitest-survival-check-html.sh
@@ -199,7 +199,6 @@ pitest-coding-2)
 pitest-coding-require-this-check)
   declare -a ignoredItems=(
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>                        &#38;&#38; ast.getParent().getType() != TokenTypes.LITERAL_CATCH) {</span></pre></td></tr>"
-  "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>                if (isAnonymousClassDef(ast)) {</span></pre></td></tr>"
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>                if (toVisit == null) {</span></pre></td></tr>"
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>               &#38;&#38; parent.getType() != TokenTypes.CTOR_DEF</span></pre></td></tr>"
   "RequireThisCheck.java.html:<td class='covered'><pre><span  class='survived'>            &#38;&#38; lastChild.getType() == TokenTypes.OBJBLOCK;</span></pre></td></tr>"

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/RequireThisCheckTest.java
@@ -443,6 +443,14 @@ public void testRecordsDefault() throws Exception {
                 expected);
     }
 
+    @Test
+    public void testAnonymousInnerClass() throws Exception {
+        final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
+
+        verifyWithInlineConfigParser(
+            getPath("InputRequireThisAnonymousInnerClass.java"), expected);
+    }
+
     @Test
     public void testUnusedMethod() throws Exception {
         final DetailAstImpl ident = new DetailAstImpl();

diff --git a/...crawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisAnonymousInnerClass.java b/...crawl/tools/checkstyle/checks/coding/requirethis/InputRequireThisAnonymousInnerClass.java
@@ -0,0 +1,46 @@
+/*
+RequireThis
+checkFields = (default)true
+checkMethods = (default)true
+validateOnlyOverlapping = (default)true
+
+
+*/
+
+package com.puppycrawl.tools.checkstyle.checks.coding.requirethis;
+
+public class InputRequireThisAnonymousInnerClass {
+    int a = 12;
+
+    void method() {
+        int a = 1;
+        InputRequireThisAnonymousInnerClass obj =
+            new InputRequireThisAnonymousInnerClass() {
+                void method() {
+                    a += 1;
+                }
+            };
+    }
+
+    void anotherMethod() {
+        int var1 = 12;
+        int var2 = 13;
+        Foo obj = new Foo() {
+            void method() {
+                var2 += var1;
+            }
+        };
+        obj.getClass();
+    }
+}
+
+class SharkFoo {
+    int var1 = 12;
+}
+
+class Foo {
+    int var2 = 13;
+
+    class SharkFoo {
+    }
+}