Release 2.10.0.6 #3028
Open
Release 2.10.0.6 #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredpar
commented
Nov 3, 2022
| @@ -57,6 +57,7 @@ public void CodeNamespace() | |||
| /// the Vim.Core assembly and not an actual reference. Too many ways that VS ships the DLL that | |||
| /// it makes referencing it too difficult. Embedding is much more reliably. | |||
| /// </summary> | |||
| // Manually verified for 2.10.0.6 | |||
There was a problem hiding this comment.
This bug is still present in the latest 17.3 release. I enabled the test locally, used the 17.4 preview toolset and verified thihs passed.
jaredpar
commented
Nov 3, 2022
| @@ -10,6 +10,7 @@ param ( | |||
| # Settings | |||
| [switch]$ci = $false, | |||
| [string]$config = "Debug", | |||
| [string]$msbuild = "", | |||
There was a problem hiding this comment.
The 17.3 toolset still has the --standalone bug. Had to manually use the 17.4 toolset to do the release. Seems valuable so I kept it.
nosami
approved these changes
Dec 13, 2022
antonkesy
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.