Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Download zipped database #3287

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

nishinji
Copy link
Contributor

Currently the compatibility database is downloaded uncompressed and is small enough in size, but it is updated frequently.
Therefore reducing the size is a good thing.

It will be decreased from 399KB to 31.6KB

@github-actions github-actions bot added build Related to the build process compat labels May 12, 2024
@Macdu
Copy link
Contributor

Macdu commented May 13, 2024

Do not use path.string().c_str() (it is not correct all the time), instead use fs_utils::path_to_utf8(path)

@nishinji
Copy link
Contributor Author

Do not use path.string().c_str() (it is not correct all the time), instead use fs_utils::path_to_utf8(path)

Fixed.

vita3k/compat/src/compat.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Macdu Macdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@Macdu Macdu merged commit 92c4646 into Vita3K:master Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to the build process compat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants