Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add macOS universal build #2847

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

KhoraLee
Copy link
Contributor

@KhoraLee KhoraLee commented Aug 10, 2023

This will add additional build of universal macOS binary which can be run natively on both Apple silicon and Intel-based macOS.
Due to compiling both architecture, CI run time will be increased

TODO:

@Macdu
Copy link
Contributor

Macdu commented Aug 12, 2023

A universal build is a nice idea. However, the longer compile time is kind of an issue. I think the MacOs compiler cache (ccache / scache) in the CI should be fixed before merging this PR.

@Macdu
Copy link
Contributor

Macdu commented Aug 12, 2023

Also it would be better not to add prebuilts to the main repo. The best would be to do like for Windows and download the prebuilts only when necessary (about unicorn)

@KhoraLee
Copy link
Contributor Author

Also it would be better not to add prebuilts to the main repo. The best would be to do like for Windows and download the prebuilts only when necessary (about unicorn)

I'm aware about unicorn. But how about FFMPEG? It is downloading all prebuilts regardless of OS.
Also I saw android version of Vita3K uses Unicorn 2, so if you don't mind could you upstream Unicorn 2 things?

@Macdu
Copy link
Contributor

Macdu commented Aug 13, 2023

Also it would be better not to add prebuilts to the main repo. The best would be to do like for Windows and download the prebuilts only when necessary (about unicorn)

I'm aware about unicorn. But how about FFMPEG? It is downloading all prebuilts regardless of OS.
Also I saw android version of Vita3K uses Unicorn 2, so if you don't mind could you upstream Unicorn 2 things?

I was only talking about unicorn here. For ffmpeg I'll need to change later the way prebuilts are downloaded. It is not a concern for this PR.

About unicorn, it is not included in the Android builds as it is GPL. But indeed when I first tried building Vita3K for Android, I was using Unicorn and updated to Unicorn 2 in the process. I'll upstream the changes.

@KhoraLee KhoraLee force-pushed the macos/ci branch 18 times, most recently from 8905273 to 50427af Compare September 6, 2023 02:11
@KhoraLee
Copy link
Contributor Author

KhoraLee commented Sep 6, 2023

Now it builds unicorn when CI process run. But due to Unicorn 1 bug, Unicorn backend will not work on arm64 macOS machines.

CI run time will be about 20~25 min

@Macdu
Copy link
Contributor

Macdu commented Sep 6, 2023

I'll do the PR to update to unicorn2 today or tomorrow.

@KhoraLee KhoraLee force-pushed the macos/ci branch 3 times, most recently from f641fe2 to fc8ebce Compare November 6, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants