Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: update #2203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README: update #2203

wants to merge 1 commit into from

Conversation

nishinji
Copy link
Contributor

@nishinji nishinji commented Nov 23, 2022 •
edited

  • Remove showcase (located on website,there are a lot of games that currently work)

@nishinji nishinji force-pushed the readme branch 2 times, most recently from d69edf2 to 427958b Compare January 18, 2023 22:35
CoffeeBrewer64
CoffeeBrewer64 reviewed Feb 14, 2023
View reviewed changes
Copy link
Contributor

@CoffeeBrewer64 CoffeeBrewer64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you want to remove the showcase? Maybe cut it down by a few but it serves as a way to show off what the emulator can do.

Also, line 48, is that the correct one? I've been told before that it's now 2020/2021/2022 by Zangetsu.

@nishinji nishinji force-pushed the readme branch 3 times, most recently from 91ddfb5 to 008187b Compare March 9, 2023 11:18
CoffeeBrewer64
CoffeeBrewer64 suggested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@CoffeeBrewer64 CoffeeBrewer64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a link to the showcase which is on the website would be better so that the person can still see it if they want to.

CoffeeBrewer64
CoffeeBrewer64 reviewed Mar 31, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@nishinji nishinji force-pushed the readme branch 2 times, most recently from 374c698 to 2ffbc2e Compare September 8, 2023 08:23
@Macdu
Copy link
Contributor

Macdu commented May 21, 2024

I'm not entirely sure about the download counter badge given that it's reset after every update I believe.

@nishinji
Copy link
Contributor Author

I'm not entirely sure about the download counter badge given that it's reset after every update I believe.

What you are saying is correct and I recognize it, but I didn't pay much attention to it.
Deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoffeeBrewer64 CoffeeBrewer64 CoffeeBrewer64 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nishinji @Macdu @CoffeeBrewer64