renderer: Use rgba16 surfaces when rgba8 is requested when needed #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zangetsu38
approved these changes
Oct 3, 2022
| this->title_id = title_id; | ||
| this->self_name = self_name; | ||
|
|
||
| static const std::string tearaway_games[] = { |
There was a problem hiding this comment.
Wouldn't it be better to store this in some kind of .xml file and then call it so that it can be edited and added on to easily? This would be helpful for anything like this in the future. idk just a thought
|
Any updates on this or it needs some reworking? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tearaway uses a feature of tiles renderer, which is that the format on the tiled renderer may be different compared to the format used to store the surface. The only way to emulate it accurately with a desktop GPU (immediate renderer) is to use a wider surface format.
As Tearaway is the only game that uses the renderer this way as far as I'm aware and that this causes an increase in memory usage, a decrease in performances and would break many games. I don't think adding it as a setting is a good idea and doing a check for Tearaway only is better.
This partially fixes the graphics in Tearaway.