Static code analyzer improvement #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try change static code analyzer to checkstyle Wire up new static code analyzer
micpiotrowski
force-pushed
the
refactor/static-code-analyzer-improvement
branch
from
b5687a9
to
c6d6090
Compare
micpiotrowski
changed the title
micpiotrowski
requested review from
PawelLipski and
mkondratek
and removed request for
PawelLipski
PawelLipski
requested changes
Mar 26, 2020
frontendUi/src/main/java/com/virtuslab/gitmachete/frontend/ui/GitMacheteGraphTableManager.java
Outdated
Show resolved
Hide resolved
frontendUi/src/main/java/com/virtuslab/gitmachete/frontend/ui/table/GraphTableModel.java
Outdated
Show resolved
Hide resolved
gitCoreJGit/src/main/java/com/virtuslab/gitcore/impl/jgit/GitCoreRepository.java
Outdated
Show resolved
Hide resolved
mkondratek
reviewed
Mar 27, 2020
mkondratek
reviewed
Mar 27, 2020
mkondratek
reviewed
Mar 27, 2020
frontendUi/src/main/java/com/virtuslab/gitmachete/frontend/ui/GitMachetePanel.java
Outdated
Show resolved
Hide resolved
|
A general note... it would be nice if some description were provided (there is a dedicated "comment field" while you are opening a PR). It makes changes easier to understand and review. Issue description commits messages, pr title usually cannot cover everything themself. In this case, it may be worth to provide and to have a look at: |
|
@micpiotrowski would be nice to regenerate the base CI image after this is merged (quite a lot of yet-unknown artifacts need to be downloaded, and spotbugs deps won't be needed anymore) |
micpiotrowski
changed the title
PawelLipski
reviewed
Mar 27, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
PawelLipski
reviewed
Mar 28, 2020
gitCoreJGit/src/main/java/com/virtuslab/gitcore/impl/jgit/GitCoreLocalBranch.java
Outdated
Show resolved
Hide resolved
micpiotrowski
changed the title
PawelLipski
approved these changes
Mar 28, 2020
mkondratek
reviewed
Mar 28, 2020
mkondratek
reviewed
Mar 28, 2020
mkondratek
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${projectRoot}/config/checkstyle/checkstyle.xmlSuppression file is in- now it was removed${projectRoot}/config/checkstyle/suppressions.xmland is included incheckstyle.xmlAvoidStarImportin checkstyleImportControlhttps://checkstyle.sourceforge.io/version/4.4/availablechecks.htmlhttps://checkstyle.sourceforge.io/checks.html - link to actual version but we use strictly version8.30so in future this link will be https://checkstyle.sourceforge.io/version/8.30/checks.htmlImportingsubfiles (DTD ENTITY): Support Multiple Configuration Files checkstyle/checkstyle#991 (comment)