Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Explicitly treat ObjectDescription._doc_field_type_map as an instance…
… variable - Aims to address [issue sphinx-doc#6478](sphinx-doc#6478) - Left ObjectDescription._doc_field_type_map declaration alone and in place in case there are other factors at play that require it declared on the class. - In ObjectDescription constructor, explicitly set _doc_field_type_map's value as an instance variable. - This presumably needs to be built with every instantiation of an ObjectDescription or inheriting class, so we're not attempting to "define it once on a class and then use it"... that approach seems much harder to reason about and get correctly done (as was maybe demonstrated by the refactoring that lead to this problem in the linked-to issue). - Runs through the test suite clean locally except for an unrelated single test failure on an image_converter test, which also failed on the base branch before my changes here.
- Loading branch information