Add ability to sign requests for all AWS services #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this would solve #2605 |
|
I have opened a similar PR at prometheus prometheus/common#380 |
Codecov Report
@@ Coverage Diff @@
## master #2604 +/- ##
==========================================
- Coverage 59.31% 59.12% -0.19%
==========================================
Files 255 255
Lines 42913 43035 +122
==========================================
- Hits 25452 25445 -7
- Misses 15772 15892 +120
- Partials 1689 1698 +9
Continue to review full report at Codecov.
|
This adds the ability to utilize sigv4 signing for all AWS services not just "aps". When the newly introduced property "service" is not set it will default to "aps". Signed-off-by: Boris Petersen <boris.petersen@idealo.de>
|
Thanks for contribution! |
valyala
pushed a commit
that referenced
this pull request
May 20, 2022
This adds the ability to utilize sigv4 signing for all AWS services not just "aps". When the newly introduced property "service" is not set it will default to "aps". Signed-off-by: Boris Petersen <boris.petersen@idealo.de>
transacid
pushed a commit
to transacid/VictoriaMetrics
that referenced
this pull request
Jul 13, 2022
Signed-off-by: Boris Petersen <boris.petersen@idealo.de>
valyala
pushed a commit
that referenced
this pull request
Jul 13, 2022
valyala
pushed a commit
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to utilize sigv4 signing for all AWS services not
just "aps". When the newly introduced property "service" is not set it
will default to "aps".
Some words about the reasoning behind this PR:
We are running VictoriaMetrics in an EKS cluster in AWS and would like to use API gateway for authentication. To sign requests for the API gateway the "service" needs to be "execute-api". However vmAgent hard codes it to be "aps.
this PR extends functionality added by #1287