Skip to content

Commit

Permalink
vmctl: fix panic on start (#3300)
Browse files Browse the repository at this point in the history
The change disables initing the `-version` flag in new
`urfave/cli/v2` update. The `-version` flag conflicts
with the identical flag from `lib/buildinfo` and causes panic.

See #3299

Signed-off-by: hagen1778 <roman@victoriametrics.com>
  • Loading branch information
hagen1778 authored and valyala committed Nov 5, 2022
1 parent b030662 commit 803ab6e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/vmctl/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ func main() {
Name: "vmctl",
Usage: "VictoriaMetrics command-line tool",
Version: buildinfo.Version,
// Disable `-version` flag to avoid conflict with lib/buildinfo flags
// see https://github.com/urfave/cli/issues/1560
HideVersion: true,
Commands: []*cli.Command{
{
Name: "opentsdb",
Expand Down

0 comments on commit 803ab6e

Please sign in to comment.