Fix: handle array-destructuring with obj assignment in prefer const

(fixes eslint#8308)
VictorHom · Jul 24, 2017 · 2cace0a · 2cace0a
1 parent 2874d75
commit 2cace0a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/lib/rules/prefer-const.js b/lib/rules/prefer-const.js
@@ -199,6 +199,17 @@ function groupByDestructuring(variables, ignoreReadBeforeAssign) {
         }
     }
 
+    for (const key of identifierMap.keys()) {
+        const destructureGroup = identifierMap.get(key);
+        const destructureElement = destructureGroup[0];
+
+        if (destructureElement && destructureElement.parent && destructureElement.parent.elements) {
+            if (destructureElement.parent.elements.length !== destructureGroup.length) {
+                identifierMap.delete(key);
+            }
+        }
+    }
+
     return identifierMap;
 }
 

diff --git a/tests/lib/rules/prefer-const.js b/tests/lib/rules/prefer-const.js
@@ -56,6 +56,12 @@ ruleTester.run("prefer-const", rule, {
         "let a; function foo() { if (a) {} a = bar(); }",
         "let a; function foo() { a = a || bar(); baz(a); }",
         "let a; function foo() { bar(++a); }",
+        "let predicate; [typeNode.returnType, predicate] = foo();",
+        "let predicate; let rest; [typeNode.returnType, predicate, ...rest] = foo();",
+        {
+            code: "let predicate; [typeNode.returnType, predicate] = foo();",
+            options: [{ destructuring: "all" }]
+        },
         {
             code: [
                 "let id;",
@@ -270,6 +276,14 @@ ruleTester.run("prefer-const", rule, {
                 { message: "'a' is never reassigned. Use 'const' instead.", type: "Identifier" }
             ]
         },
+        {
+            code: "let [ foo, bar ] = baz();",
+            output: "const [ foo, bar ] = baz();",
+            errors: [
+                { message: "'foo' is never reassigned. Use 'const' instead.", type: "Identifier" },
+                { message: "'bar' is never reassigned. Use 'const' instead.", type: "Identifier" }
+            ]
+        },
         {
             code: "let {a} = obj",
             output: "const {a} = obj",