feat: lock very_good_cli version in workflow #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirpal
requested review from
felangel,
renancaraujo and
wolfenrain
as code owners
wolfenrain
previously approved these changes
Feb 21, 2023
felangel
reviewed
Feb 21, 2023
wolfenrain
reviewed
Feb 21, 2023
…workflows into chore/lock-cli-version
Kirpal
requested review from
renancaraujo,
wolfenrain and
felangel
and removed request for
renancaraujo and
wolfenrain
felangel
reviewed
Feb 22, 2023
| @@ -43,6 +43,10 @@ on: | |||
| required: false | |||
| type: boolean | |||
| default: false | |||
| very_good_cli_version: | |||
There was a problem hiding this comment.
See my comment on #90 (comment) about not tightly coupling the public API of the workflow to very_good_cli since very_good_cli is just an implementation detail imo. I think we should instead just restrict the workflow to a specific version range dart pub global activate very_good_cli <0.2.0
felangel
suggested changes
Feb 22, 2023
|
Closing this in favor of this comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added an input which locks the very_good_cli version, in case of breaking changes. Closes #90 .
Type of Change