Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lock the version of the CLI in the workflows #90

Open
wolfenrain opened this issue Nov 7, 2022 · 2 comments
Open

feat: lock the version of the CLI in the workflows #90

wolfenrain opened this issue Nov 7, 2022 · 2 comments
Labels
feature A new feature or request good first issue Good for newcomers

Comments

@wolfenrain
Copy link
Member

Description

We need to lock the CLI in the workflows in case we ever have a breaking change on it, currently it installs the latest and if people use older version of the workflows when there is a breaking change it will break that workflow accidentally.
@wolfenrain wolfenrain added bug Something isn't working as expected feature A new feature or request and removed bug Something isn't working as expected labels Nov 7, 2022
@felangel felangel added the good first issue Good for newcomers label Nov 28, 2022
@Kirpal Kirpal mentioned this issue Feb 10, 2023
Closed
7 tasks
@Kirpal
Copy link

Kirpal commented Feb 14, 2023

In review, PR #101

@felangel
Copy link
Contributor

Rather than exposing an input to customize very_good_cli in the workflow shouldn't we treat breaking changes in very_good_cli as breaking changes in the workflow? I would rather not expose inputs in the workflow that tightly couple the workflow to very_good_cli since in the future we may decide to move away from very_good_cli (it's an internal implementation detail imo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature A new feature or request good first issue Good for newcomers
Projects
VGV Open Source 🦄 🧙🌟
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: lock very_good_cli version in workflow Kirpal/very_good_workflows
4 participants
@renancaraujo @felangel @wolfenrain @Kirpal