Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v3.1.0 #51

Merged
merged 10 commits into from Sep 19, 2022
Merged

feat: v3.1.0 #51

merged 10 commits into from Sep 19, 2022

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Jul 22, 2022 •
edited by felangel

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the feature A new feature or request label Jul 22, 2022
@felangel
Copy link
Contributor

Thanks for the PR! I’ll take a closer look early next week 👍

This was linked to issues Sep 8, 2022
Add recommended lints that are missing from the package #49
Closed
feat: Remove deprecated "Invariant booleans" #50
Closed
@felangel felangel changed the title feat: v3.0.2 feat: add recommended lints and remove deprecated invariant_booleans Sep 8, 2022
@felangel felangel changed the title feat: add recommended lints and remove deprecated invariant_booleans feat: add recommended lints, remove deprecated invariant_booleans Sep 8, 2022
renancaraujo
renancaraujo previously approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depend_on_referenced_packages will be a noisy update. But necessary IMO.

@felangel felangel changed the title feat: add recommended lints, remove deprecated invariant_booleans feat: add recommended lints Sep 14, 2022
@felangel
Copy link
Contributor

I'm working on reviewing the remaining new lint rules and will update this PR with all of the changes shortly. We can then release this as v3.1.0 if everyone is onboard.

@felangel felangel changed the title feat: add recommended lints feat: v3.1.0 Sep 14, 2022
@felangel felangel removed the request for review from deremer September 15, 2022 16:48
@felangel felangel self-assigned this Sep 15, 2022
@lsaudon lsaudon removed their assignment Sep 16, 2022
renancaraujo
renancaraujo previously approved these changes Sep 19, 2022
View reviewed changes
@felangel felangel merged commit 3f0eb08 into VeryGoodOpenSource:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@wolfenrain wolfenrain wolfenrain approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees

@felangel felangel

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Remove deprecated "Invariant booleans" Add recommended lints that are missing from the package
4 participants
@lsaudon @felangel @renancaraujo @wolfenrain