Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended lints that are missing from the package #49

Closed
dmiedev opened this issue Jul 6, 2022 · 1 comment · Fixed by #51
Closed

Add recommended lints that are missing from the package #49

dmiedev opened this issue Jul 6, 2022 · 1 comment · Fixed by #51
Assignees
Labels
feature A new feature or request

Comments

@dmiedev
Copy link

dmiedev commented Jul 6, 2022

Hey,

I've noticed there are three lints that are recommended by Flutter team through the flutter_lints package but are missing from the very_good_analysis package:

  • no_leading_underscores_for_library_prefixes
  • no_leading_underscores_for_local_identifiers
  • depend_on_referenced_packages

Could they get potentially added into the package? Or is there a reason they aren't included? They're pretty unharmful, from my point of view. Anyway, thanks in advance for considering my suggestion.

Cheers!

@wujekbogdan
Copy link

wujekbogdan commented Jul 11, 2022

To keep this package in sync with original linter rules it might be a good idea to do:

include: package:flutter_lints/flutter.yaml

So that all base rules are always up to date with package:flutter_lints and package:lints (package:flutter_lints already includes lints). Then just add missing rules to linter.rules:

linter:
  rules:
   - very_good_rules

It might be also a good idea to mentions, somewhere in the docs, that very_good_analysis is a superset of package:flutter_lints/flutter.yaml.

I'm new to Flutter and it took me a while to understand what very_good_analysis really is. I wasn't sure whether it is an opinionated set of rules developed by Very Good Ventures or is it rather based on "original" linter rules. It turned out to be the latter.

I had to write a little script that does w diff on 2 rules sets to figure it out ;)

@lsaudon lsaudon mentioned this issue Jul 22, 2022
7 tasks
@felangel felangel self-assigned this Sep 8, 2022
@felangel felangel linked a pull request Sep 8, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants