-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: avoid false negatives when the current version is a pre-release and there is a prior stable release on pub #42
Conversation
…d and there is a prior stable release
65923cf
to
71449ef
Compare
.thenAnswer((_) => Future.value(FakeProcessResult())); | ||
}); | ||
|
||
test('returns false when currentVersion < latestVersion', () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So just to clarify if the current version was 0.1.0-dev.48
and the latest version was 1.0.0
, isUpToDate
would return true
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, in short, I think we shouldn't track how "up to date" a pre-release is when compared to a stable release because it is a rabbit hole (#41 (comment))
I also had the same doubt that @felangel had here. Can we add some documentation in the Maybe a FAQ similar to how mocktail or very_good_coverage have? |
ac1e683
to
99a27ea
Compare
Co-authored-by: Jochum van der Ploeg <jochum@vdploeg.net>
Description
fix!: avoid false negatives when the current version is a pre-release and there is a prior stable release on pub
This is a breaking change, in the following case, that returned
false
, will returntrue
after this change.closes: #41
Type of Change