feature: [VRD-682] Client utility function to translate import module names into distribution package names #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule name are correctly captured
…arty package names
…a given set of import module names
ewagner-verta
commented
Mar 8, 2023
ewagner-verta
commented
Mar 8, 2023
… dependency checking
ewagner-verta
commented
Mar 8, 2023
ewagner-verta
commented
Mar 8, 2023
liuverta
suggested changes
Mar 8, 2023
…ncluded packages is included in the env and return a more useful error message for missing packages
liuverta
suggested changes
Mar 9, 2023
client/verta/tests/unit_tests/registry/test_check_model_dependencies.py
Outdated
Show resolved
Hide resolved
client/verta/tests/unit_tests/registry/test_model_dependencies.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
liuverta
suggested changes
Mar 10, 2023
client/verta/tests/unit_tests/registry/test_check_model_dependencies.py
Outdated
Show resolved
Hide resolved
liuverta
suggested changes
Mar 10, 2023
There was a problem hiding this comment.
I re-opened a prior comment thread: #3652 (comment). We should have some test coverage of multiple missing modules.
That should be the last thing! Everything else looks good.
liuverta
reviewed
Mar 10, 2023
Co-authored-by: Liu <96442646+liuverta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact and Context
This is the missing piece of functionality for the client method
check_model_dependenciesto work properly.The importlib.metadata module is used to capture info about the distribution packages for each of the import modules extracted from a model class.
Risks and Area of Effect
Fairly low risk, as this is net new functionality on the first iteration and it's all hidden from the docs for now.
The Python ecosystem does not enforce package naming conventions, and the
importlibdocs warn:This seems to be related specifically to editable installs. However I experimented with
vertaas aneditableinstallation, and thenameattribute we need is there.Testing
Reverting