Skip to content

Commit

Permalink
chore: Allow protobuf < 4.0 to support M1 Macs (#3070)
Browse files Browse the repository at this point in the history
* chore: Allow protobug < 4.0

* Remove no-space-check

* Ignore protobuf.struct_pb2 in pylint
  • Loading branch information
liuverta committed Jul 29, 2022
1 parent 4c1d440 commit c63622a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
10 changes: 2 additions & 8 deletions client/verta/.pylintrc
Expand Up @@ -285,7 +285,8 @@ ignored-classes=optparse.Values,
# (useful for modules/projects where namespaces are manipulated during runtime
# and thus existing member attributes cannot be deduced by static analysis. It
# supports qualified module names, as well as Unix pattern matching.
ignored-modules=verta._protos.*
ignored-modules=verta._protos.*,
google.protobuf.struct_pb2,

# Show a hint with possible names when a member name was not found. The aspect
# of finding the hint is based on edit distance.
Expand Down Expand Up @@ -351,13 +352,6 @@ max-line-length=100
# Maximum number of lines in a module
max-module-lines=1000

# List of optional constructs for which whitespace checking is disabled. `dict-
# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}.
# `trailing-comma` allows a space between comma and closing bracket: (a, ).
# `empty-line` allows space-only lines.
no-space-check=trailing-comma,
dict-separator

# Allow the body of a class to be on the same line as the declaration if body
# contains single statement.
single-line-class-stmt=no
Expand Down
2 changes: 1 addition & 1 deletion client/verta/requirements.txt
Expand Up @@ -2,7 +2,7 @@ click >= 7.0, < 9.0
cloudpickle ~= 1.0
googleapis-common-protos >= 1.5, < 2.0
pathlib2 >= 2.2, < 3.0
protobuf >= 3.8, < 3.18
protobuf >= 3.8, < 4.0
pytimeparse >= 1.1.8, < 2.0
pyyaml >= 5.1, < 6.0
requests >= 2.21, < 3.0

0 comments on commit c63622a

Please sign in to comment.