Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotenv-webpack to work around storybookjs/storybook#14403 #821

Merged
merged 1 commit into from
Jun 9, 2021

Commits on Jun 9, 2021

  1. Add dotenv-webpack to work around storybookjs/storybook#14403

    storybookjs/storybook#14497 and storybookjs/storybook#14403
    
    tl;dr: Happo stopped working after #818 was merged, it turns out it is because
    `npm run build-storybook` crashed due to the above issue(s).
    
    Theoretically this is a workaround and can be removed after storybookjs/storybook#14403 is resolved, but there is no sign of when that'll happen
    
    Deep technical reasons from the linked issue for why this fails:
    
    > If npm hoists dotenv-webpack 6.0.4 to the node_modules root, everything works fine. However, if npm hoists dotenv-webpack 1.8, and the user has a .env file present, start-storybook fails to run.
    >
    > Unless the user is already pinning dotenv-webpack, the version that gets hoisted depends on how many dependencies are using 1.8 vs 6.0.4. (For example, in the repro steps below, if you remove @storybook/addon-essentials, npm hoists 6.0.4 and things work normally.) This makes for some extremely surprising and hard-to-pin-down behavior.
    leonm1 committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    836b4dc View commit details
    Browse the repository at this point in the history