Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8-bugbear 指摘事項の修正 (b027) #538

Merged
merged 1 commit into from Dec 26, 2022

Conversation

sarisia
Copy link
Contributor

@sarisia sarisia commented Dec 26, 2022

内容

flake8-bugbear 22.10.25 以降で追加されたチェックルール (B027: Empty method in abstract base class with no abstract decorator) に違反するコードを修正します.

この PR では, B027 を 無視 します. 指摘のあった initialize_speaker_synthesis() は, docstring にもある通り,

未実装の場合は何もしない

のが仕様です. よって, これは抽象メソッドではなく, @abstractmethod デコレータを付与する必要はありません (実際, 付与するとテストが落ちます).

関連 Issue

この指摘事項は #535 で依存関係 (flake8-bugbear) がアップグレードされた際に検出されました. #535 のマージにはこの PR のマージが必要です.

当該の Run: https://github.com/VOICEVOX/voicevox_engine/actions/runs/3776794325/jobs/6420846964

スクリーンショット・動画など

その他

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 154 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 206 166 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 133 12 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 129 6 coverage-95%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
TOTAL 1237 262 coverage-79%

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

丁寧な進行、ありがとうございます!!

@Hiroshiba Hiroshiba merged commit f84c2d6 into VOICEVOX:master Dec 26, 2022
@sarisia sarisia deleted the fix-b027 branch January 6, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants