Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Java APIのPC用ビルドを追加 #764

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

sevenc-nanashi
Copy link
Member

@sevenc-nanashi sevenc-nanashi commented Mar 25, 2024

内容

タイトル通りです。
download-artifactがv4になってpattern指定できるようになったのでリファクタついでに。

関連 Issue

(なし)

その他

サンプル:https://github.com/sevenc-nanashi/voicevox_core/actions/runs/8419271673

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっとちゃんとわかってないですがほぼLGTMかなと!!

.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Outdated Show resolved Hide resolved
crates/voicevox_core_java_api/lib/build.gradle Outdated Show resolved Hide resolved
.github/workflows/build_and_deploy.yml Show resolved Hide resolved
Copy link
Member

@qryxip qryxip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私からは特にありません。LGTM!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほぼLGTMです!!

とやかく言っちゃってすみません!
良いコードになっていると感じました!!

@qryxip qryxip requested a review from Hiroshiba May 11, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants