Refactor: SettingDialog.vueのトグルボタンを共通化 #1954
Merged
+194
−469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
（誤爆しました、スマホ版GitHubだとDraft解除がワンボタンでできるのなんとかして欲しい…） |
|
ドラフト明けました！ スクリーンショットテストを行われているので見た目上は多分問題ないはず。 |
|
多分大丈夫だと思うのでマージします！ |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
SettingDialog.vueをリファクタリングするタスクです。
とりあえず一番利用頻度の多いトグルボタンだけコンポーネント化しました。
とりあえず今回のだけでも350行くらい減ったはず。
MenuBarみたいにMenuItemを構造化してitemsをコンポーネントに渡して描画してもらう方法も考えたのですが、UIの種類が特殊なのもあること、あとサクッとUIを足すこともできるようにしたいことから、とりあえずUIの種類ごとにコンポーネントを作り、それを足す形で進めてみました。
関連 Issue
その他
が先です。