Constrain python-dateutil #268
Closed
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-hilden
commented
Aug 15, 2023
| @@ -1,5 +1,6 @@ | |||
| ## Next | |||
| * (Minor) Switch to ruff for linting and black for formatting. | |||
| * (Minor) Constrain the version of `python-dateutil` appropriately to `>=2.8.1` to avoid an import error. Thanks @felix-hilden! | |||
There was a problem hiding this comment.
I'm not sure how you want to classify this. Let me know and I can edit!
|
Looks like the resolver is failing on 3.10. This happens on the other PR as well, so I'll assume it's unrelated. |
|
Hey @felix-hilden, so sorry I missed this. I'm going to close this in favour of #273 , which should keep older versions of dateutil working rather than pinning the version. Absolutely feel free to reopen this if you think I did a dumb thing by closing it |
|
Oh that's way better, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Constrain python-dateutil to avoid an import error, as discussed in #266.
Type of change
Please delete options that are not relevant.