Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] cron should gracefully reload process (closes #5636) #5637

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix] cron should gracefully reload process (closes #5636) #5637

wants to merge 1 commit into from

Conversation

titanism
Copy link

Per #5636. This should be at minimum a minor semver bump, but recommended major semver bump.

@titanism
[fix] cron should gracefully reload process (closes Unitech#5636)
0df629a 
Per <Unitech#5636>.  This should be at minimum a minor semver bump, but recommended major semver bump.
@titanism titanism mentioned this pull request Jul 10, 2023
Open
@CLAassistant
Copy link

CLAassistant commented Jul 10, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

hinogi
hinogi approved these changes Aug 26, 2023
View reviewed changes
Copy link

@hinogi hinogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtizzy
Copy link

rtizzy commented Oct 3, 2023

Great work! Just happened to run into this myself while debugging some issues.

Is this going to be brought into mainline anytime soon?

@titanism
Copy link
Author

titanism commented Oct 3, 2023

@rtizzy don't forget to set pmx: false to avoid the PM2 memory leak too FYI, these both are unresolved still, not sure if @Unitech is still maintaining PM2 actively or wants help - just let us know if so, we are "titanism" on npm/GitHub and maintain a ton of projects including @forwardemail @spamscanner @ladjs and lots of @koajs stuff.

#5145 (comment)

@titanism
Copy link
Author

titanism commented Dec 7, 2023

ping @Unitech

1 similar comment
@titanism
Copy link
Author

ping @Unitech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinogi hinogi hinogi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@titanism @CLAassistant @rtizzy @hinogi