Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing npm audit: mkdirp #4641

Closed
wants to merge 1 commit into from
Closed

Fix failing npm audit: mkdirp #4641

wants to merge 1 commit into from

Conversation

DMeechan
Copy link

NPM Audit was failing with mkdirp@0.5.1 so I've upgraded it to 0.5.3.

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4638
License MIT
Doc PR https://github.com/pm2-hive/pm2-hive.github.io/pulls

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2020

CLA assistant check
All committers have signed the CLA.

@DMeechan DMeechan marked this pull request as ready for review March 23, 2020 11:07
@DMeechan
Copy link
Author

Tests passed locally with Node 12. Any ideas why it breaks with Node 10?

@StevenChin
Copy link

Any updates on this?

@DMeechan
Copy link
Author

@StevenChin While waiting for this to be resolved, I ended up doing:

npm i git+https://github.com/DMeechan/pm2.git

It's not ideal but I hope that helps if you're blocked on this like we were 😄

@StevenChin
Copy link

Thanks @DMeechan! I just might have to do that unfortunately.

@Unitech
Copy link
Owner

Unitech commented Apr 12, 2020

mkdirp upgraded to ^1, in the development branch for now, follow this issue to know when it is released: #4638

Or:

npm install Unitech/pm2#development -g

@Unitech Unitech closed this Apr 12, 2020
@DMeechan DMeechan deleted the dm/minimist-npm-audit branch April 15, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants