Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disabling logs #4561

Merged
merged 2 commits into from Apr 12, 2020
Merged

Fix disabling logs #4561

merged 2 commits into from Apr 12, 2020

Conversation

codpot
Copy link
Contributor

@codpot codpot commented Dec 28, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #4560
License MIT

Unitech and others added 2 commits December 10, 2019 19:28
@Unitech
pm2@4.2.1
5ad2446
@codpot
Fix disabling logs bugs (#4560)
f3259c0 
When log path set to "/dev/null" in Windows, PM2 creates 'C:\dev\null'.
After remove "C:\dev" folder while PM2 is stopped, PM2 can't restart app.
Because, Path changed to "C:\dev\null" not "/dev/null" in Windows.
(libs/Utility.js - 174)
When log path set to "NULL" in Windows and Linux and flush logs,
PM2 creates 'NULL' in source code directory.

So, If log path is "NULL" or "/dev/null" then
forces path to "\\.\NUL" when Windows and "/dev/null" when Linux.
It works both on Windows and Linux, without any create "C:\dev" or "NULL".
@claassistantio
Copy link

claassistantio commented Dec 28, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@Unitech Unitech merged commit bf582e1 into Unitech:development Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codpot @claassistantio @Unitech