馃帹 Style nits #51
Merged
馃帹 Style nits #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
transmissions11
commented
Oct 23, 2022
src/DomainSeparator.sol
Outdated
Comment on lines
22
to
28
| /// @notice Returns the domain separator for the current chain. | ||
| /// @dev Uses cached version if chainid and address are unchanged from construction. | ||
| function DOMAIN_SEPARATOR() public view returns (bytes32) { | ||
| if (address(this) == _CACHED_THIS && block.chainid == _CACHED_CHAIN_ID) { | ||
| return _CACHED_DOMAIN_SEPARATOR; | ||
| } else { | ||
| return _buildDomainSeparator(_TYPE_HASH, _HASHED_NAME); | ||
| } | ||
| return | ||
| block.chainid == _CACHED_CHAIN_ID | ||
| ? _CACHED_DOMAIN_SEPARATOR | ||
| : _buildDomainSeparator(_TYPE_HASH, _HASHED_NAME); |
There was a problem hiding this comment.
as discussed the this address(this) stuff isnt rly needed
There was a problem hiding this comment.
and removing it should give us a lil gas savings
There was a problem hiding this comment.
why should we care about supporting delegatecalls at our own expense? this case is unique from OZ's convo because it is logical that tokens could want to delegatecall ERC20 impls with EIP712 mixed in, but no one should be delegatecaling permit2
There was a problem hiding this comment.
that's fair - happy to leave it out then
snreynolds
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.