feat: Phase 0 NavBar #4285
Closed
feat: Phase 0 NavBar #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cbachmeier
commented
Aug 4, 2022
•
cbachmeier
commented
- NavBar for token explore
- Features old wallet
- Hidded behind Feature Flag
- Requires the correct env variables as mentioned in slack
- There are a couple of difference between this NavBar and the one merged into interface-nft, notably some style changes as well as hiding NFT specific components
- Code in the /nft/components folder are some shared wrapper components used across NFT design including an overlay, createPortal wrapper, and Box, Row, Column, which import vanilla extract sprinkles directly
…e-main-interface-repository' into WEB-726-feature-flag-navbar
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vm
reviewed
Aug 12, 2022
vm
reviewed
Aug 12, 2022
vm
reviewed
Aug 12, 2022
|
This PR has a lot of features at once, could we split it up into...
|
vm
reviewed
Aug 15, 2022
|
|
||
| if (!chainId || !info || !provider) { | ||
| // TODO: need to handle unsupported chain | ||
| if (!chainId || !info) { |
There was a problem hiding this comment.
need to render a state for unsupported chains
vm
force-pushed
the
WEB-726-feature-flag-navbar
branch
from
5d2e8cd
to
4fad5cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.