Upgrade react-scripts to 5.0.1

[podliashanyk]

react-scripts 5.0.1 introduced breaking changes. Read more in create-react-app changelog.

Breaking changes relevant for Argus were:

• Imports of SVG files failed. This is due to a known bug in react-scripts v5. Estimated time until fix is unknown, but very likely not soon.
• Eslint config files that were not automatically applied in Argus, started to be automatically applied as soon as on dev build (!) and were blocking rendering in browser (both in dev and in prod). Reported issue After update to 4.0 lint errors are blocking the rendering facebook/create-react-app#9887 (comment). Explanation as to why it happens in After update to 4.0 lint errors are blocking the rendering facebook/create-react-app#9887 (comment)
• jest-environment-jsdom-sixteen was no longer supported

Changes made:

• Dependencies:
  • bumped react-scripts
  • bumped jest-environment-jsdom
  • bumped jest
• Config:
  • eslint config files are renamed from default names to custom names. This is to control where and when eslint config is to be applied instead of create-react-app applying to by default to the scripts.
• Compressed SVG. Solution suggested in Bug: [5.0] SVGs cannot be imported (not as components, but regular import) facebook/create-react-app#11770 (comment)

NB

package.json is changed and package-lock.json is committed in this PR

[codecov-commenter]

Codecov Report

Merging #505 (cd43082) into master (7880157) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   57.52%   57.43%   -0.09%     
==========================================
  Files          86       86              
  Lines        3597     3656      +59     
  Branches      753      812      +59     
==========================================
+ Hits         2069     2100      +31     
- Misses       1519     1547      +28     
  Partials        9        9              

Impacted Files	Coverage Δ
src/api/client.ts	38.96% <ø> (-0.14%)	⬇️
src/auth.tsx	100.00% <ø> (ø)
src/components/incident/IncidentDetails.tsx	46.52% <ø> (-0.66%)	⬇️
src/components/incident/IncidentFilterToolbar.tsx	60.62% <ø> (-0.64%)	⬇️
...components/incidenttable/RealtimeIncidentTable.tsx	1.98% <ø> (-0.02%)	⬇️
...ts/notificationprofile/NotificationProfileList.tsx	43.26% <ø> (ø)
src/components/timeslot/index.tsx	89.94% <ø> (-0.19%)	⬇️
src/components/timeslotlist/index.tsx	77.41% <ø> (-0.85%)	⬇️

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hmpf]

Curious, why so many lines with eslint-disable-next-line?

I can't get this to work against newest backend master, exception from backend when clicking on "Profiles".

Otherwise most of the changes seems to be turning off eslint.

[podliashanyk]

Curious, why so many lines with eslint-disable-next-line?

Eslint rules are useful most of time, but sometimes they can be a hindrance (f.e. exhaustive deps rule in hooks makes it impossible to have a "on-mount" and "on-unmount" useEffect). But there are some eslint-disable-next-line in the code base that can be removed.

[hmpf]

Survived quick manual test