-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add static typing support #1302
base: master
Are you sure you want to change the base?
Conversation
Thanks! Looks good - but why did you add a new workflow to run stubtest, instead of adding the extra test to the existing workflows? |
Good question. I just took the changes from the previous PR #1279 After the holidays I can continue to work on this and use the existing workflows. |
Looks you like need to add |
I was the author of #1279 , something went wrong with my pr and when I noticed this one was already made. Which is perfectly fine but now this pr has been dead for 5 months. |
Hey, I was just very busy the last months. And thanks for your initial work, it was very helpful to get started. |
Closes: #1298
Lots of this PR was stolen from #1279
Notice: I intentionally reversed the import behavior of
__init__.py
and_netCDF4.pyx
in the stubs. This should be more in line in how people are using netCDF4. And while doing so I also removed the "._netCDF4" part of the classname in the reprs.The current typing is working with python 3.11.
TODO: