Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more descriptive error message if indexing with all False bool … #1197

Closed
wants to merge 7 commits into from
Closed

Added more descriptive error message if indexing with all False bool … #1197

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c30cb71
Added more descriptive error message if indexing with all False bool …
tammasloughran Oct 4, 2022
5e4e903
Moved error message
tammasloughran Oct 9, 2022
ab787f1
return empty array if boolean index array is all False
jswhit Oct 11, 2022
d70c336
update
jswhit Oct 11, 2022
60702d1
add test for all False boolean index slicing multi-dim array
jswhit Oct 11, 2022
78a93b0
Merge remote-tracking branch 'upstream/boolFalse_getitem'
tammasloughran Oct 12, 2022
4f37a43
Changed to warning
tammasloughran Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/netCDF4/utils.py
View file
Open in desktop
Expand Up @@ -208,6 +208,12 @@ def _StartCountStride(elem, shape, dimensions=None, grp=None, datashape=None,\
if sum(1 for e in elem if e is Ellipsis) > 1:
raise IndexError("At most one ellipsis allowed in a slicing expression")

# Check if elem is valid for bool array.
if type(elem) is np.ndarray:
if elem.dtype is np.dtype(bool) and np.logical_not(np.any(elem))
raise IndexError("All elements of bool indexing array are False. "
"At least one element must be True to be valid.")

# replace boolean arrays with sequences of integers.
newElem = []
IndexErrorMsg=\
Expand Down