NEXRAD Updates #1251
Merged
NEXRAD Updates #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attribute commented out isn't even referenced anywhere else. The fact that this was commented out in column 1 (rather than with a properly indented #) was causing pydocstyle to choke on it.
Really just need to be a bit less exacting and allow for some padding bytes. (Data are not yet operational.)
dopplershift
added
Area: IO
Update for latest draft ICD. Also better adjust to changing sizes.
Instead of relying on the version encoded for the volume, look at the size of the radial constant blocks.
dopplershift
force-pushed
the
fix-nexrad
branch
from
dd998a0
to
e12854f
Compare
The moments vary from sweep to sweep, but we were always reading 6 pointers rather than looking at the encoded value. This would have bitten us when they started shipping a 7th moment with Build 19.
Instead of using the sphinx-autogen script, we can now, as of Sphinx 2.1, just set a couple variables in conf.py. This is good, because running the script seems completely broken with 2.3.
Not sure why we were adding Cygwin to the PATH, but it breaks setuptools_scm.
dopplershift
force-pushed
the
fix-nexrad
branch
from
e12854f
to
2c1ffc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
A variety of fixes and clean-ups for NEXRAD:
Level2FileLevel3File. It was unnecessary and its poor indentation was breakingpydocstyleThis also tweaks the doc build to hopefully unbreak CI. I moved the sphinx-autosummary config to
conf.pyand it seems to work fine (so long as we bump to a minimum of 2.1). This is needed because running the script as we did before seems borked (sphinx-doc/sphinx#6936)Checklist