fix Bytes signatures. Byte is a span-type, it should be passed by value

UdjinM6 · Sep 6, 2022 · 7089a38 · 7089a38
1 parent 78b5fb5
commit 7089a38
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/elements.cpp b/src/elements.cpp
@@ -105,7 +105,7 @@ G1Element G1Element::FromMessage(const std::vector<uint8_t>& message,
     return FromMessage(Bytes(message), dst, dst_len);
 }
 
-G1Element G1Element::FromMessage(const Bytes& message,
+G1Element G1Element::FromMessage(Bytes const message,
                                  const uint8_t* dst,
                                  int dst_len)
 {
@@ -315,7 +315,7 @@ G2Element G2Element::FromMessage(const std::vector<uint8_t>& message,
     return FromMessage(Bytes(message), dst, dst_len, fLegacy);
 }
 
-G2Element G2Element::FromMessage(const Bytes& message,
+G2Element G2Element::FromMessage(Bytes const message,
                                  const uint8_t* dst,
                                  int dst_len,
                                  const bool fLegacy)
@@ -448,7 +448,7 @@ G2Element operator*(const bn_t& k, const G2Element& a) { return a * k; }
 
 const size_t GTElement::SIZE;
 
-GTElement GTElement::FromBytes(const Bytes& bytes)
+GTElement GTElement::FromBytes(Bytes const bytes)
 {
     if (bytes.size() != SIZE) {
         throw std::invalid_argument("GTElement::FromBytes: Invalid size");

diff --git a/src/elements.hpp b/src/elements.hpp
@@ -47,7 +47,7 @@ class G1Element {
     static G1Element FromMessage(const std::vector<uint8_t> &message,
                                  const uint8_t *dst,
                                  int dst_len);
-    static G1Element FromMessage(const Bytes& message,
+    static G1Element FromMessage(Bytes message,
                                  const uint8_t* dst,
                                  int dst_len);
     static G1Element Generator();
@@ -89,7 +89,7 @@ class G2Element {
                                  const uint8_t* dst,
                                  int dst_len,
                                  bool fLegacy = false);
-    static G2Element FromMessage(const Bytes& message,
+    static G2Element FromMessage(Bytes message,
                                  const uint8_t* dst,
                                  int dst_len,
                                  bool fLegacy = false);
@@ -117,7 +117,7 @@ class G2Element {
 class GTElement {
 public:
     static const size_t SIZE = 384;
-    static GTElement FromBytes(const Bytes& bytes);
+    static GTElement FromBytes(Bytes bytes);
     static GTElement FromByteVector(const std::vector<uint8_t> &bytevec);
     static GTElement FromNative(const gt_t *element);
     static GTElement Unity();  // unity