Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colors package #337

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Fix colors package #337

merged 1 commit into from
Nov 29, 2022

Conversation

JuhG
Copy link
Contributor

@JuhG JuhG commented Nov 21, 2022

Fixes #332

@robhil
Copy link
Contributor

robhil commented Nov 29, 2022

Hi, @JuhG I followed these steps #332 (comment), and tbh I can't reproduce it :( Version 1.4.0 was installed. As you can see here https://www.npmjs.com/package/colors?activeTab=readme current version is 1.4.0 and here Marak/colors.js#289 you can check that author removed the broken version 🤔 As I saw on the attached screenshot you are using different registry npm. accretivetg.com. Maybe there you have to update something? 🤔

@JuhG
Copy link
Contributor Author

JuhG commented Nov 29, 2022

Hey @robhil, you're right. It works with the default npm registry. The problem is that I need to use the company registry to use company packages.

Probably this was one of the reasons the package was moved under a new name: https://www.npmjs.com/package/@colors/colors
See issue here: Marak/colors.js#340

In my opinion it's not a great idea to use a package that's still under the name of Marak as he intentionally wanted to break the internet. He didn't remove the broken package, npm did.

All in all I understand if you don't want to deal with this. Thanks for taking the time!
We'll probably fork this repo and fix it there.

@robhil
Copy link
Contributor

robhil commented Nov 29, 2022

@JuhG Thank you for your reply. I didn't realize that the author intentionally wanted to break the internet 😱 Now this change makes sense to me. Thank you very much for your contribution!

@robhil robhil merged commit 784018d into UXPin:master Nov 29, 2022
@robhil
Copy link
Contributor

robhil commented Nov 29, 2022

@JuhG FYI, from now you can use 2.8.2 version https://github.com/UXPin/uxpin-merge-tools/blob/master/packages/uxpin-merge-cli/CHANGELOG.md#282---2022-11-29 :)

@JuhG
Copy link
Contributor Author

JuhG commented Nov 29, 2022

Thanks a lot @robhil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colors package breaks CLI
2 participants