Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3007) Change transparency identifier #2320

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

CristinaRO
Copy link
Collaborator

@CristinaRO CristinaRO commented Jan 17, 2024

Changes in this PR

For activities that will be continuing under DSIT:

  • change their transparency identifier to replace the string "GB-GOV-13" with "GB-GOV-26"; e.g. GB-GOV-13-ISPF-UKSA-AH2TS7K-SPB9U87 becomes GB-GOV-26-ISPF-UKSA-AH2TS7K-SPB9U87
  • change the providing_organisation_reference for all their actuals, from "GB-GOV-13" to "GB-GOV-26"
  • change the providing_organisation_reference for all their forecasts, from "GB-GOV-13" to "GB-GOV-26"

This type of data change would be better suited for a data migration or a rake task, but both of those would require access to the application console in the production environment.

Screenshots of UI changes

Before

After

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

@CristinaRO CristinaRO force-pushed the 3006-change-continuing-activities branch from a73294b to e0f8a97 Compare January 17, 2024 16:03
@CristinaRO CristinaRO requested a review from mec January 17, 2024 18:13
@mec mec self-assigned this Jan 18, 2024
Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

For activities that will be continuing under DSIT:
- change their transparency identifier to replace the string "GB-GOV-13"
with "GB-GOV-26"; e.g. `GB-GOV-13-ISPF-UKSA-AH2TS7K-SPB9U87` becomes
`GB-GOV-26-ISPF-UKSA-AH2TS7K-SPB9U87`
- change the `providing_organisation_reference` for all their actuals,
from "GB-GOV-13" to "GB-GOV-26"
- change the `providing_organisation_reference` for all their forecasts,
from "GB-GOV-13" to "GB-GOV-26"

This type of data change would be better suited for a data migration or
a rake task, but both of those would require access to the application
console in the production environment.
@CristinaRO CristinaRO force-pushed the 3006-change-continuing-activities branch from e0f8a97 to 0004bbb Compare January 19, 2024 14:28
@CristinaRO CristinaRO marked this pull request as ready for review January 19, 2024 14:34
@CristinaRO CristinaRO merged commit 1673bff into develop Jan 19, 2024
3 checks passed
@CristinaRO CristinaRO deleted the 3006-change-continuing-activities branch January 19, 2024 14:42
CristinaRO added a commit that referenced this pull request Jan 19, 2024
…ntinuing-activities"

This reverts commit 1673bff, reversing
changes made to 8ba7b20.
CristinaRO added a commit that referenced this pull request Jan 22, 2024
Revert "Merge pull request #2320 from UKGovernmentBEIS/3006-change-co…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants