Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(3005) Change DSIT organisations' IATI references and names #2311

Merged
merged 3 commits into from
Jan 19, 2024
Merged

(3005) Change DSIT organisations' IATI references and names #2311

merged 3 commits into from
Jan 19, 2024

Conversation

CristinaRO
Copy link
Collaborator

@CristinaRO CristinaRO commented Jan 15, 2024 •
edited

Changes in this PR

  • Change the transparency identifier and names for the DSIT organisations (DSIT and DSIT Finance)

Screenshots of UI changes

Before

Screenshot 2024-01-19 at 11 57 48
Screenshot 2024-01-19 at 11 57 55

After

Screenshot 2024-01-19 at 12 14 54
Screenshot 2024-01-19 at 12 14 44

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

@CristinaRO
Copy link
Collaborator Author

New DSIT org ID: update the service owner organisation and its satellite org with the new name and IATI reference

@CristinaRO CristinaRO requested a review from mec January 17, 2024 18:13
@mec mec self-assigned this Jan 18, 2024
shuldt
shuldt approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@shuldt shuldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mec
mec approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@mec mec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@CristinaRO CristinaRO marked this pull request as ready for review January 19, 2024 11:42
@CristinaRO
Change the service owner's IATI reference
24f441a 
As a consequence of BEIS having become DSIT, the organisation has
received a new IATI reference.

In this commit we change the organisation details through a migration,
as well as the constant used to identify the service owner organisation.
@CristinaRO
Update documentation and hints to use new ID
a91d477
@CristinaRO
Change spec to use a non-reserved IATI reference
fed1498 
The spec is correct with regards to format, but it can give the wrong
impression about using that specific identifier for a non-service owner
organisation.
@CristinaRO CristinaRO merged commit 8ba7b20 into develop Jan 19, 2024
3 checks passed
@CristinaRO CristinaRO deleted the 3005-new-dsit-org-id branch January 19, 2024 11:58
CristinaRO added a commit that referenced this pull request Jan 22, 2024
@CristinaRO
Revert "Merge pull request #2311 from UKGovernmentBEIS/3005-new-dsit-…
6057caf 
…org-id"

This reverts commit 8ba7b20, reversing
changes made to 49e892f.
CristinaRO added a commit that referenced this pull request Jan 23, 2024
@CristinaRO
Merge pull request #2333 from UKGovernmentBEIS/revert-service-owner-m…
83a7c9f 
…igration

Revert "Merge pull request #2311 from UKGovernmentBEIS/3005-new-dsit-…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mec mec mec approved these changes

@shuldt shuldt shuldt approved these changes

Assignees

@mec mec

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@CristinaRO @mec @shuldt