An attempt to fix issue with navigation links on mobile #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've updated the comment above with screen shots of before and after. |
|
Very nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2547
I'm opening this PR for initial review of the solution.
The idea was to move the navigation links to the same place as the sidebar links on mobile devices.
I have added the navigation links to the sidebar links.
I have removed the toolbar links on mobile using css.
I have changed the css so that navigation links are not displayed in the sidebar when not on mobile device.
I have tested by coping the resulting build to my project's node_modules.
Before:
After:
