New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search boosts #1930
Merged
Merged
Search boosts #1930
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
2844af7
wip
adb740e
kind boosting
6870ceb
ts fixes
5ec06bc
boost on category
84ccef0
restore minify
356ab3d
remove debugger
aa7483f
ignore case
ca60240
shorten imports
d9a60fc
lint
8d2a6e5
lint
009a244
don't write empty string
shmax 545fc88
boost on exact by default
shmax 6a41cee
precompute category boosts
shmax ee9b66e
remove dep on ReflectionKind
shmax aa9a272
chain
shmax b68ede6
don't export IDocument
shmax 735ac30
remove import
shmax 9e9af66
remove numResults
shmax 8864deb
splip up SearchConfig
shmax d0bdf5a
fix search
shmax 26d4a9a
remove dom
shmax f30213b
lint
shmax 54abe77
precompute all boosts
shmax 3601b26
validate group boosts
shmax ae839ef
coalesce
shmax d6e5b18
use original case
shmax 09d7c26
Add additional validation for boost options
Gerrit0 7ca811b
Merge branch 'master' into search-boosts
Gerrit0 45bf9da
Fix CI
Gerrit0 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd like to split this up into a few options:
I think it makes sense to always give exact matches a large boost, probably needs experimentation to figure out what that should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed
exactMatch
from the config stuff, and now it's on by default.545fc88
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8864deb
(removed the numResults thing; we don't need it right now, and I don't want to needlessly prolong this review)