Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support export-declaration #1079

Closed
wants to merge 1 commit into from
Closed

support export-declaration #1079

wants to merge 1 commit into from

Conversation

shrinktofit
Copy link

@aciccarello
Copy link
Collaborator

@shrinktofit Can you add tests to ensure we don't regress on this?

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jul 26, 2019

We should evaluate this next to #801, which makes a lot more changes and may be a more complete implementation. (In particular, the changes it makes for handling renames appear to be rather important)

It might be best to merge this until we have the time to get to 801.

@gnidan
Copy link

gnidan commented Sep 19, 2019

Firstly: I published this and #1096 as NPM @gnd/typedoc for anyone that wants to try this out. ℹ️

Secondly... I noticed a problem; not sure if it's with this PR, but it seems related... the problem appears when I use this syntax along with the --excludeNotExported flag.

import * as Utils from "./utils";
export { Utils };

Doing this, I would expect Utils to appear in the docs output, but it's missing, even though it's clearly exported.

Here, some screenshots to show the difference:

Without the flag, Utils is there Screen Shot 2019-09-19 at 7 25 34 PM
But when you pass --excludeNotExported, it's missing! 😱 Screen Shot 2019-09-19 at 7 31 13 PM

I threw up a demo repo here for anyone that's looking to reproduce: https://github.com/gnidan-finds-bugs/typedoc-pull-1079

Hope this is useful information. Let me know if there's anything I can do to help!

@gnidan
Copy link

gnidan commented Nov 3, 2019

Can this get scheduled for 0.16 as well? Not sure what the status is in relation to #801

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 3, 2019

This should be superceded by #801

@Gerrit0 Gerrit0 added this to the 0.16.0 milestone Nov 10, 2019
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Nov 10, 2019

Adding this to the 0.16 as at least one of this & #801 needs to be merged, and after spending a few hours understanding how 801 works yesterday, I want to go over this PR more carefully, I think the method used to convert modules here might be better.

@Bnaya
Copy link

Bnaya commented Dec 1, 2019

hey @gnidan any chance to publish updated gnd/typedoc? :)

@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 12, 2020

#1157 has been merged, which includes support for export declarations :)

Thank you for the PR, it proved quite useful in determining how best to handle export declarations.

@Gerrit0 Gerrit0 closed this Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants