Normalize path for Windows

TypeStrong · Mar 31, 2024 · 3398e98 · 3398e98
1 parent cf80261
commit 3398e98
Show file tree

Hide file tree

Showing 8 changed files with 168 additions and 167 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -5,7 +5,7 @@ jobs:
         runs-on: ubuntu-latest
         strategy:
             matrix:
-                node: ["16", "18", "20"]
+                node: ["18", "20", "22"]
         name: Node ${{ matrix.node }}
         steps:
             - name: Checkout repository

diff --git a/.github/workflows/publish-beta.yml b/.github/workflows/publish-beta.yml
@@ -18,7 +18,7 @@ jobs:
               if: steps.check.outputs.changed == 'true' && contains(steps.check.outputs.version, 'beta')
               uses: actions/setup-node@v1
               with:
-                  node-version: "16"
+                  node-version: "20"
             - name: Upgrade npm
               if: steps.check.outputs.changed == 'true' && contains(steps.check.outputs.version, 'beta')
               run: npm i -g npm@latest

diff --git a/.github/workflows/publish-lts.yml b/.github/workflows/publish-lts.yml
@@ -18,7 +18,7 @@ jobs:
               if: steps.check.outputs.changed == 'true'
               uses: actions/setup-node@v3
               with:
-                  node-version: "16"
+                  node-version: "20"
             - name: Upgrade npm
               if: steps.check.outputs.changed == 'true'
               run: npm i -g npm@latest

diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -20,7 +20,7 @@ jobs:
               if: steps.check.outputs.changed == 'true'
               uses: actions/setup-node@v3
               with:
-                  node-version: "16"
+                  node-version: "20"
             - name: Install
               if: steps.check.outputs.changed == 'true'
               run: npm ci

diff --git a/.github/workflows/visual-regression.yml b/.github/workflows/visual-regression.yml
@@ -9,7 +9,7 @@ jobs:
             - name: Set up Node
               uses: actions/setup-node@v3
               with:
-                  node-version: 16
+                  node-version: 20
             - name: Upgrade npm
               run: npm i -g npm@latest
             - name: Get baseline screenshots

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,17 +37,17 @@
     "@types/marked": "^4.0.8",
     "@types/mocha": "^10.0.6",
     "@types/node": "16",
-    "@typescript-eslint/eslint-plugin": "^7.1.1",
-    "@typescript-eslint/parser": "^7.1.1",
+    "@typescript-eslint/eslint-plugin": "^7.4.0",
+    "@typescript-eslint/parser": "^7.4.0",
     "@typestrong/fs-fixture-builder": "github:TypeStrong/fs-fixture-builder#8abd1494280116ff5318dde2c50ad01e1663790c",
     "c8": "^9.1.0",
-    "esbuild": "^0.20.1",
+    "esbuild": "^0.20.2",
     "eslint": "^8.57.0",
-    "mocha": "^10.3.0",
+    "mocha": "^10.4.0",
     "prettier": "3.0.3",
     "puppeteer": "^13.5.2",
     "ts-node": "^10.9.2",
-    "typescript": "5.4.2"
+    "typescript": "5.4.3"
   },
   "files": [
     "/bin",

diff --git a/src/test/Repository.test.ts b/src/test/Repository.test.ts
@@ -7,6 +7,7 @@ import { tempdirProject } from "@typestrong/fs-fixture-builder";
 import { spawnSync } from "child_process";
 import { TestLogger } from "./TestLogger";
 import { join } from "path";
+import { normalizePath } from "../lib/utils/paths";
 
 describe("Repository", function () {
     describe("guessSourceUrlTemplate helper", () => {
@@ -153,7 +154,7 @@ describe("Repository", function () {
 
             ok(repo);
             equal(
-                repo.getURL(join(project.cwd, "test.js"), 1),
+                repo.getURL(normalizePath(join(project.cwd, "test.js")), 1),
                 "b53cc55bcdd9bc5920787a1d4a4a15fa24123b04/b53cc55b/test.js/1",
             );
         });