Use getCheckFlags, closes #2203

TypeStrong · Mar 19, 2023 · 015de24 · 015de24
1 parent ebf1b7b
commit 015de24
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 16 deletions.
diff --git a/scripts/compare_screenshots.sh b/scripts/compare_screenshots.sh
@@ -4,6 +4,7 @@ test -d ./tmp/output && rm -rf ./tmp/output
 mkdir -p ./tmp/{output,screenshots,baseline}
 
 docker run \
+    --rm \
     --name typedoc-reg-suit \
     -v "$PWD/tmp/screenshots:/new" \
     -v "$PWD/tmp/baseline:/old" \

diff --git a/src/lib/converter/symbols.ts b/src/lib/converter/symbols.ts
@@ -1021,11 +1021,8 @@ function setModifiers(
     );
     reflection.setFlag(
         ReflectionFlag.Readonly,
-        hasAllFlags(
-            // TS 4.9: symbol.checkFlags, links was introduced in 5.0
-            symbol.checkFlags ?? symbol.links?.checkFlags ?? 0,
-            ts.CheckFlags.Readonly
-        ) || hasAllFlags(modifiers, ts.ModifierFlags.Readonly)
+        hasAllFlags(ts.getCheckFlags(symbol), ts.CheckFlags.Readonly) ||
+            hasAllFlags(modifiers, ts.ModifierFlags.Readonly)
     );
     reflection.setFlag(
         ReflectionFlag.Abstract,

diff --git a/src/lib/types/ts-internal/index.d.ts b/src/lib/types/ts-internal/index.d.ts
@@ -10,16 +10,6 @@ declare module "typescript" {
     }
 
     interface Symbol {
-        // TS before 5.0
-        // https://github.com/microsoft/TypeScript/blob/v4.1.5/src/compiler/types.ts#L4734-L4737
-        checkFlags?: CheckFlags;
-
-        // TS 5.0
-        // https://github.com/microsoft/TypeScript/blob/5.0.2/src/compiler/types.ts#L5891-L5898
-        links?: {
-            checkFlags: CheckFlags;
-        };
-
         // https://github.com/microsoft/TypeScript/blob/v4.7.4/src/compiler/types.ts#L4941
         // https://github.com/microsoft/TypeScript/issues/38344
         parent?: ts.Symbol;
@@ -36,6 +26,8 @@ declare module "typescript" {
         getTypeOfSymbol(symbol: Symbol): Type;
     }
 
+    export function getCheckFlags(symbol: ts.Symbol): CheckFlags;
+
     export interface Signature {
         thisParameter?: ts.Symbol;
     }

diff --git a/src/test/renderer/testProject/tsconfig.json b/src/test/renderer/testProject/tsconfig.json
@@ -6,7 +6,8 @@
         "experimentalDecorators": true,
         "resolveJsonModule": true,
         "rootDir": ".",
-        "esModuleInterop": true
+        "esModuleInterop": true,
+        "skipLibCheck": true
     },
     "include": ["."]
 }