This repository has been archived by the owner on Aug 14, 2021. It is now read-only.
support export declarations #57
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! When I get a chance to review I'll merge this. |
lddubeau
force-pushed
the
feature/export-declarations
branch
from
93565d0
to
fa1b1f4
Compare
The themes previously did not visually distinguish those symbols that are exported from those that are not exported. This commit modifies the theme to make the distinction. The relevantFlags helper is required due to changes to typedoc. Typedoc would previously arbitrarily narrow the array of flags recorded in reflections to those that the default (and minimal) themes care about. Typedoc has been changed to include all the flags in the array and let the themes decide which flags are relevant to them.
lddubeau
force-pushed
the
feature/export-declarations
branch
from
966c1a4
to
3b5d22d
Compare
aciccarello
added
the
related-typedoc-pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR which is companion to a PR about to be submitted to typedoc. Both the PR here and the PR there need to be applied together to provide the functionality that is added.
I'll update this PR with a reference to the typedoc PR once it is submitted.
ETA: this is the companion PR on the typedoc side.