Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add REPL top level await support #1383

Merged
merged 83 commits into from Aug 8, 2021
Merged

feat: add REPL top level await support #1383

merged 83 commits into from Aug 8, 2021

Commits on Jul 10, 2021

  1. feat: add repl top level await support

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    e8dc156 View commit details
    Browse the repository at this point in the history

  2. refactor: add more files as dist-raw, adjust primordial imports

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    cb0b9f0 View commit details
    Browse the repository at this point in the history

  3. refactor: add flag support for experimental repl await

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    95b3385 View commit details
    Browse the repository at this point in the history

  4. refactor: add support for Typescript input in experimental repl await

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    3e2e9ab View commit details
    Browse the repository at this point in the history

  5. refactor: conditionally await eval result

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    0335a36 View commit details
    Browse the repository at this point in the history

  6. chore: update node-repl-await file

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    907a25b View commit details
    Browse the repository at this point in the history

  7. refactor: dynamically exclude TLA diagnostics when --experimental-rep… 

    …l-await is set
    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    b8fe6aa View commit details
    Browse the repository at this point in the history

  8. refactor: exclude sourceMap when transpiling for experimentalReplAwait

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    e3063c4 View commit details
    Browse the repository at this point in the history

  9. refactor: add acorn & acorn-walk as dependencies and remove them from… 

    … dist-raw
    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    ec5611d View commit details
    Browse the repository at this point in the history

  10. refactor: allow setting experimentalReplAwait via env & tsconfig

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    d1c667b View commit details
    Browse the repository at this point in the history

  11. refactor: adjust evalCode signature to avoid being a breaking change

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    d2b2ee0 View commit details
    Browse the repository at this point in the history

  12. refactor: improve top level await mechanism

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    40060c3 View commit details
    Browse the repository at this point in the history

  13. refactor: adjust ignored diagnostic codes related to top level await/… 

    …for await
    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    ce11fec View commit details
    Browse the repository at this point in the history

  14. refactor: use evalCodeInternal and revert evalCode to previous signature

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    f8a89a0 View commit details
    Browse the repository at this point in the history

  15. refactor: await evalAndExitOnTsError result during bin main

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    4032134 View commit details
    Browse the repository at this point in the history

  16. refactor: adjust node-primordials

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    621bd63 View commit details
    Browse the repository at this point in the history

  17. chore: remove unused require

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    9cba099 View commit details
    Browse the repository at this point in the history

  18. refactor: revert to previous implementation of node-primordials, add … 

    …missing methods
    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    22f9b4f View commit details
    Browse the repository at this point in the history

  19. refactor: adjust node-repl-await to use compatible syntax up to node 12

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    1e1f793 View commit details
    Browse the repository at this point in the history

  20. fix: typo in node-repl-await

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    ff39161 View commit details
    Browse the repository at this point in the history

  21. refactor: add unhandledRejection listener

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    b8d44ea View commit details
    Browse the repository at this point in the history

  22. chore: remove node-primordials dts

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    a431018 View commit details
    Browse the repository at this point in the history

  23. fix: typo in node version comparison

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    7f0e177 View commit details
    Browse the repository at this point in the history

  24. test: add top level await tests

    @ejose19
    ejose19 committed Jul 10, 2021
    Copy the full SHA
    4bca34c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2021

  1. test: fix tla test

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    5ad56a2 View commit details
    Browse the repository at this point in the history

  2. test: add upstream test suite of tla

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    40d78e1 View commit details
    Browse the repository at this point in the history

  3. feat: allow REPL to be configured on start

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    784c46e View commit details
    Browse the repository at this point in the history

  4. refactor: return repl server on start

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    d24fe23 View commit details
    Browse the repository at this point in the history

  5. refactor: use a different context when useGlobal = false

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    69f2977 View commit details
    Browse the repository at this point in the history

  6. test: adjust upstream tests to latest changes

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    af297a4 View commit details
    Browse the repository at this point in the history

  7. refactor: adjust new line placement on top level await processing

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    bdfbb91 View commit details
    Browse the repository at this point in the history

  8. refactor: adjust ignored codes related to TLA

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    fd49cca View commit details
    Browse the repository at this point in the history

  9. test: adjust TLA tests

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    d50b991 View commit details
    Browse the repository at this point in the history

  10. refactor: override target when experimental repl await is set

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    19d1589 View commit details
    Browse the repository at this point in the history

  11. test: adjust tla test

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    cf81617 View commit details
    Browse the repository at this point in the history

  12. test: adjust tla tests

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    4e505e2 View commit details
    Browse the repository at this point in the history

  13. test: adjust tla tests

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    6d49e8a View commit details
    Browse the repository at this point in the history

  14. test: move tla upstream tests to a separate file

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    072064e View commit details
    Browse the repository at this point in the history

  15. refactor: lazy load processTopLevelAwait

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    3c11fc9 View commit details
    Browse the repository at this point in the history

  16. refactor: correctly handle errors for async eval result

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    a3c488e View commit details
    Browse the repository at this point in the history

  17. refactor: throw error if target is not compatible with experimental r… 

    …epl await
    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    9abb693 View commit details
    Browse the repository at this point in the history

  18. refactor: adjust main call in bin

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    f81a5ef View commit details
    Browse the repository at this point in the history

  19. refactor: don't exclude tla diagnostic codes when mode is "entrypoint"

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    261e82f View commit details
    Browse the repository at this point in the history

  20. refactor: move new repl start implementation to startInternal

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    e45d2ed View commit details
    Browse the repository at this point in the history

  21. fix: typo in config

    @ejose19
    ejose19 committed Jul 11, 2021
    Copy the full SHA
    3a5ed72 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. test: adjust tla tests

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    22efd1b View commit details
    Browse the repository at this point in the history

  2. test: normalize object usage in commandline

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    64f04d9 View commit details
    Browse the repository at this point in the history

  3. test: move upstream tla deps from testlib to its file

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    ce3487e View commit details
    Browse the repository at this point in the history

  4. test: fix formatObjectCommandLine

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    e6c6433 View commit details
    Browse the repository at this point in the history

  5. refactor: adjust type assertion

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    507fcd3 View commit details
    Browse the repository at this point in the history

  6. refactor: adjust _eval to iterate changes using a for loop

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    ef26938 View commit details
    Browse the repository at this point in the history

  7. refactor: adjust execution implementation in nodeEval

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    5b0fc39 View commit details
    Browse the repository at this point in the history

  8. test: add tla test

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    81e5e71 View commit details
    Browse the repository at this point in the history

  9. refactor: fix processTopLevelAwait return type

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    b68ed6f View commit details
    Browse the repository at this point in the history

  10. refactor: restore main to sync, implement callback mechanism

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    48778ad View commit details
    Browse the repository at this point in the history

  11. refactor: small adjustments in repl

    @ejose19
    ejose19 committed Jul 12, 2021
    Copy the full SHA
    31424ad View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. refactor: remove TLA support from [stdin] & [eval]

    @ejose19
    ejose19 committed Jul 13, 2021
    Copy the full SHA
    3ac743b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. refactor: adjust tla tests

    @ejose19
    ejose19 committed Jul 14, 2021
    Copy the full SHA
    e35f1d6 View commit details
    Browse the repository at this point in the history

  2. refactor: improve code reuse in repl tests

    @ejose19
    ejose19 committed Jul 14, 2021
    Copy the full SHA
    2c09d2d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2021

  1. Add raw/node-repl-await.js for easier diffing in the future

    @cspotcode
    cspotcode committed Jul 18, 2021
    Copy the full SHA
    2c1e8bf View commit details
    Browse the repository at this point in the history

  2. Rename flag to --no-experimental-repl-await to match node; enable by … 

    …default when target is high enough; avoid `process.exit()` in `create()`; change `await` detection heuristic to match node's
    @cspotcode
    cspotcode committed Jul 18, 2021
    Copy the full SHA
    1418bd3 View commit details
    Browse the repository at this point in the history

  3. Minimize changes to bin, since the only async possibility is in REPL,… 

    … so bin.ts does not need to handle its errors
    @cspotcode
    cspotcode committed Jul 18, 2021
    Copy the full SHA
    629a4cc View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. Merge remote-tracking branch 'origin/main' into ej/replTopLevelAwait

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    6a102a7 View commit details
    Browse the repository at this point in the history

  2. Integrate with latest main branch

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    c39640e View commit details
    Browse the repository at this point in the history

  3. fix test

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    05cb7b8 View commit details
    Browse the repository at this point in the history

  4. fix tests

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    051f9e1 View commit details
    Browse the repository at this point in the history

  5. fix

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    4788cb3 View commit details
    Browse the repository at this point in the history

  6. fix

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    4aaac4c View commit details
    Browse the repository at this point in the history

  7. fix tests

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    8c84ef7 View commit details
    Browse the repository at this point in the history

  8. fix test; make test-local fix linting errors instead of blocking on them

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    35bee32 View commit details
    Browse the repository at this point in the history

  9. fix

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    f535423 View commit details
    Browse the repository at this point in the history

  10. normalize paths passed to diagnosticFilters to hopefully fix windows … 

    …tests
    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    3489501 View commit details
    Browse the repository at this point in the history

  11. force repl's virtual file to be a module, which is safe as long as no… 

    …de's runtime effectively does the same thing
    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    1fa5bdd View commit details
    Browse the repository at this point in the history

  12. remove extraneous prop deletion in show-config output

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    8a772ab View commit details
    Browse the repository at this point in the history

  13. remove some todos

    @cspotcode
    cspotcode committed Jul 22, 2021
    Copy the full SHA
    c44a3d6 View commit details
    Browse the repository at this point in the history

  14. Update src/repl.ts 

    Co-authored-by: ejose19 <8742215+ejose19@users.noreply.github.com>
    @cspotcode @ejose19
    cspotcode and ejose19 committed Jul 22, 2021
    Copy the full SHA
    781a886 View commit details
    Browse the repository at this point in the history

  15. refactor: move forceToBeModule from createRepl to startRepl

    @ejose19
    ejose19 committed Jul 22, 2021
    Copy the full SHA
    d50a80e View commit details
    Browse the repository at this point in the history

  16. test: adjust tests

    @ejose19
    ejose19 committed Jul 22, 2021
    Copy the full SHA
    aa31ffc View commit details
    Browse the repository at this point in the history

  17. test: set static target for TLA tests

    @ejose19
    ejose19 committed Jul 22, 2021
    Copy the full SHA
    3a6562d View commit details
    Browse the repository at this point in the history

  18. refactor: show hint regarding tla errors when shouldReplAwait=false

    @ejose19
    ejose19 committed Jul 22, 2021
    Copy the full SHA
    2e276b9 View commit details
    Browse the repository at this point in the history

  19. test: small adjustments

    @ejose19
    ejose19 committed Jul 22, 2021
    Copy the full SHA
    6d0b486 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2021

  1. Final cleanup

    @cspotcode
    cspotcode committed Aug 8, 2021
    Copy the full SHA
    e985fd0 View commit details
    Browse the repository at this point in the history

  2. increase wait time in repl test to reduce flakiness

    @cspotcode
    cspotcode committed Aug 8, 2021
    Copy the full SHA
    fae10d4 View commit details
    Browse the repository at this point in the history