Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1202 supplemental: add --no-implicit-compiler-options which disables loading of implicit @tsconfig/bases #1249

Closed
wants to merge 12 commits into from

Conversation

cspotcode
Copy link
Collaborator

@cspotcode cspotcode commented Feb 26, 2021

Supplement to #1202

Decided not to add this flag until it's requested. Users can always write a tsconfig.json which should cover their needs, so this flag may never be needed.

The code is here in this branch in case we need to add it in the future.

This branch may not merge cleanly due to git history weirdness, but you should be able to generate a diff between this branch and the repo immediately after #1236 was merged.

Creating as closed to keep the PR queue clean.

@cspotcode cspotcode closed this Feb 26, 2021
@cspotcode cspotcode reopened this May 19, 2021
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #1249 (7816ac7) into master (4e04302) will increase coverage by 0.34%.
The diff coverage is 92.00%.

❗ Current head 7816ac7 differs from pull request most recent head 994044d. Consider uploading reports for the commit 994044d to get more accurate results
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/bin.ts | 89.10% <ø> (ø) | |
| src/index.ts | 80.57% <84.61%> (+0.14%) | ⬆️ |
| src/tsconfigs.ts | 100.00% <100.00%> (ø) | |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant