Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ERR_REQUIRE_ESM when a file is require()d which should be loaded as ESM #1031

Merged
merged 18 commits into from May 20, 2020
Merged

Implement ERR_REQUIRE_ESM when a file is require()d which should be loaded as ESM #1031

merged 18 commits into from May 20, 2020

Commits on May 3, 2020

  1. revert addition of package.json "exports" because it is a breaking ch… 

    …ange and requires more thought
    @cspotcode
    cspotcode committed May 3, 2020
    Copy the full SHA
    2bee85e View commit details
    Browse the repository at this point in the history

Commits on May 9, 2020

  1. Implement ERR_REQUIRE_ESM error when attempting to require() an ESM file

    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    c2ab1c3 View commit details
    Browse the repository at this point in the history

  2. fix

    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    d82df95 View commit details
    Browse the repository at this point in the history

  3. test on node 12.15 and 12.16 due to weird ESM handling

    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    a10c7a9 View commit details
    Browse the repository at this point in the history

  4. Switch package.json "type" feature detection to a simple version numb… 

    …er check
    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    7243123 View commit details
    Browse the repository at this point in the history

  5. Remove dead code

    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    eb07ff6 View commit details
    Browse the repository at this point in the history

  6. Only throw ERR_REQUIRE_ESM if experimental ESM loader is enabled, sin… 

    …ce it is a breaking change
    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    567acb6 View commit details
    Browse the repository at this point in the history

  7. Fix linter failures

    @cspotcode
    cspotcode committed May 9, 2020
    Copy the full SHA
    f5fab01 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2020

  1. Merge remote-tracking branch 'origin/master' into ab/add-err-require-… 

    …esm-error
    @cspotcode
    cspotcode committed May 11, 2020
    Copy the full SHA
    dcc7e0d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Merge remote-tracking branch 'origin/master' into ab/add-err-require-… 

    …esm-error
    @cspotcode
    cspotcode committed May 16, 2020
    Copy the full SHA
    8076998 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @cspotcode
    cspotcode committed May 16, 2020
    Copy the full SHA
    d70658b View commit details
    Browse the repository at this point in the history

  3. fix test?

    @cspotcode
    cspotcode committed May 16, 2020
    Copy the full SHA
    b1c35b8 View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @cspotcode
    cspotcode committed May 16, 2020
    Copy the full SHA
    5e8090a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2020

  1. Merge remote-tracking branch 'origin/master' into ab/add-err-require-… 

    …esm-error
    @cspotcode
    cspotcode committed May 17, 2020
    Copy the full SHA
    da76779 View commit details
    Browse the repository at this point in the history

  2. add comments to explain copy-pasted cjs loader code from node core

    @cspotcode
    cspotcode committed May 17, 2020
    Copy the full SHA
    9f9efd6 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2020

  1. Merge remote-tracking branch 'origin/master' into ab/add-err-require-… 

    …esm-error
    @cspotcode
    cspotcode committed May 18, 2020
    Copy the full SHA
    6b15230 View commit details
    Browse the repository at this point in the history

  2. fix

    @cspotcode
    cspotcode committed May 18, 2020
    Copy the full SHA
    7a1a55b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2020

  1. tweak comment

    @cspotcode
    cspotcode committed May 20, 2020
    Copy the full SHA
    1a21a7d View commit details
    Browse the repository at this point in the history